Mercurial > pidgin
view src/stringref.h @ 12645:fc28451f5d96
[gaim-migrate @ 14983]
SF Patch #1314512 from Sadrul (who has a patch for everything)
"This patch introduces a flag for protocol plugins that
support offline messages (like Y!M and ICQ). This was
encouraged by the following conversation:
<sadrul> should offline buddies be listed/enabled in
the send-to menu?
<rekkanoryo> i would think only for protocols that
support offline messaging, if it's indicated that the
buddy is offline
-- <snip> --
<Bleeter> sadrul: personally, I'd like to see a
'supports offline' flag of some description
<Bleeter> one could then redirect (via plugins) through
email or alternative methods
<Bleeter> just a thought
<Paco-Paco> yeah, that sounds like a reasonble thing to have
This patch uses this flag to disable the buddies in the
send-to menu who are offline and the protocol doesn't
support offline messages."
I made this make the label insensitive instead of the whole menuitem. This
should address SimGuy's concerns about inconsistency (i.e. you could create a
conversation with someone via the buddy list that you couldn't create via the
Send To menu). I also hacked up some voodoo to show the label as sensitive when
moused-over, as that looks better (given the label-insensitive thing is itself a
hack). I think this works quite well.
BUG NOTE:
This makes more obvious an existing bug. The Send To menu isn't updated when
buddies sign on or off or change status (at least under some circumstances).
We need to fix that anyway, so I'm not going to let it hold up this commit.
Switching tabs will clear it up. I'm thinking we just might want to build the
contents of that menu when it is selected. That would save us a mess of
inefficient signal callbacks that update the Send To menus in open windows all
the time.
AIM NOTE:
This assumes that AIM can't offline message. That's not strictly true. You can
message invisible users on AIM. However, by design, we can't tell when a user
is invisible without resorting to dirty hackery. In practice, this isn't a
problem, as you can still select the AIM user from the menu. And really, how
often will you be choosing the Invisible contact, rather than the user going
Invisible in the middle of a conversation or IMing you while they're Invisible?
JABBER NOTE:
This assumes that Jabber can always offline message. This isn't strictly true.
Sadrul said:
I have updated Jabber according to this link which seems to
talk about how to determine the existence offline-message
support in a server:
http://www.jabber.org/jeps/jep-0013.html#discover
However, jabber.org doesn't seem to send the required
info. So I am not sure about it.
He later said:
I talked to Nathan and he said offline message support is
mostly assumed for most jabber servers. GTalk doesn't yet
support it, but they are working on it. So I have made
jabber to always return TRUE.
If there is truly no way to detect offline messaging capability, then this is
an acceptable solution. We could special case Google Talk because of its
popularity, and remove that later. It's probably not worth it though.
MSN NOTE:
This assumes that MSN can never offline message. That's effectively true, but
to be technically correct, MSN can offline message if there's already a
switchboard conversation open with a user. We could write an offline_message
function in the MSN prpl to detect that, but it'd be of limited usefulness,
especially given that under most circumstances (where this might matter), the
switchboard connection will be closed almost immediately.
CVS NOTE:
I'm writing to share a tragic little story.
I have a PC that I use for Gaim development. One day, I was writing a commit
message on it, when all of a suddent it went berserk. The screen started
flashing, and the whole commit message just disappeared. All of it. And it was
a good commit message! I had to cram and rewrite it really quickly. Needless to
say, my rushed commit message wasn't nearly as good, and I blame the PC for that.
Seriously, though, what kind of version control system loses your commit
message on a broken connection to the server? Stupid!
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Fri, 23 Dec 2005 19:26:04 +0000 |
| parents | db62420a53a2 |
| children |
line wrap: on
line source
/** * @file stringref.h Reference-counted immutable strings * @ingroup core * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #ifndef _GAIM_STRINGREF_H_ #define _GAIM_STRINGREF_H_ /** * The internal representation of a stringref. * * @note For this structure to be useful, the string contained within * it must be immutable -- for this reason, do _not_ access it * directly! */ typedef struct _GaimStringref { guint32 ref; /**< The reference count of this string. * Note that reference counts are only * 31 bits, and the high-order bit * indicates whether this string is up * for GC at the next idle handler... * But you aren't going to touch this * anyway, right? */ char value[1]; /**< The string contained in this ref. * Notice that it is simply "hanging * off the end" of the ref ... this * is to save an allocation. */ } GaimStringref; /** * Creates an immutable reference-counted string object. The newly * created object will have a reference count of 1. * * @param value This will be the value of the string; it will be * duplicated. * * @return A newly allocated string reference object with a refcount * of 1. */ GaimStringref *gaim_stringref_new(const char *value); /** * Creates an immutable reference-counted string object. The newly * created object will have a reference count of zero, and if it is * not referenced before the next iteration of the mainloop it will * be freed at that time. * * @param value This will be the value of the string; it will be * duplicated. * * @return A newly allocated string reference object with a refcount * of zero. */ GaimStringref *gaim_stringref_new_noref(const char *value); /** * Creates an immutable reference-counted string object from a printf * format specification and arguments. The created object will have a * reference count of 1. * * @param format A printf-style format specification. * * @return A newly allocated string reference object with a refcount * of 1. */ GaimStringref *gaim_stringref_printf(const char *format, ...); /** * Increase the reference count of the given stringref. * * @param stringref String to be referenced. * * @return A pointer to the referenced string. */ GaimStringref *gaim_stringref_ref(GaimStringref *stringref); /** * Decrease the reference count of the given stringref. If this * reference count reaches zero, the stringref will be freed; thus * you MUST NOT use this string after dereferencing it. * * @param stringref String to be dereferenced. */ void gaim_stringref_unref(GaimStringref *stringref); /** * Retrieve the value of a stringref. * * @note This value should not be cached or stored in a local variable. * While there is nothing inherently incorrect about doing so, it * is easy to forget that the cached value is in fact a * reference-counted object and accidentally use it after * dereferencing. This is more problematic for a reference- * counted object than a heap-allocated object, as it may seem to * be valid or invalid nondeterministically based on how many * other references to it exist. * * @param stringref String reference from which to retrieve the value. * * @return The contents of the string reference. */ const char *gaim_stringref_value(const GaimStringref *stringref); /** * Compare two stringrefs for string equality. This returns the same * value as strcmp would, where <0 indicates that s1 is "less than" s2 * in the ASCII lexicography, 0 indicates equality, etc. * * @param s1 The reference string. * * @param s2 The string to compare against the reference. * * @return An ordering indication on s1 and s2. */ int gaim_stringref_cmp(const GaimStringref *s1, const GaimStringref *s2); /** * Find the length of the string inside a stringref. * * @param stringref The string in whose length we are interested. * * @return The length of the string in stringref */ size_t gaim_stringref_len(const GaimStringref *stringref); #endif /* _GAIM_STRINGREF_H_ */
