Mercurial > pidgin
view src/protocols/msn/error.c @ 12645:fc28451f5d96
[gaim-migrate @ 14983]
SF Patch #1314512 from Sadrul (who has a patch for everything)
"This patch introduces a flag for protocol plugins that
support offline messages (like Y!M and ICQ). This was
encouraged by the following conversation:
<sadrul> should offline buddies be listed/enabled in
the send-to menu?
<rekkanoryo> i would think only for protocols that
support offline messaging, if it's indicated that the
buddy is offline
-- <snip> --
<Bleeter> sadrul: personally, I'd like to see a
'supports offline' flag of some description
<Bleeter> one could then redirect (via plugins) through
email or alternative methods
<Bleeter> just a thought
<Paco-Paco> yeah, that sounds like a reasonble thing to have
This patch uses this flag to disable the buddies in the
send-to menu who are offline and the protocol doesn't
support offline messages."
I made this make the label insensitive instead of the whole menuitem. This
should address SimGuy's concerns about inconsistency (i.e. you could create a
conversation with someone via the buddy list that you couldn't create via the
Send To menu). I also hacked up some voodoo to show the label as sensitive when
moused-over, as that looks better (given the label-insensitive thing is itself a
hack). I think this works quite well.
BUG NOTE:
This makes more obvious an existing bug. The Send To menu isn't updated when
buddies sign on or off or change status (at least under some circumstances).
We need to fix that anyway, so I'm not going to let it hold up this commit.
Switching tabs will clear it up. I'm thinking we just might want to build the
contents of that menu when it is selected. That would save us a mess of
inefficient signal callbacks that update the Send To menus in open windows all
the time.
AIM NOTE:
This assumes that AIM can't offline message. That's not strictly true. You can
message invisible users on AIM. However, by design, we can't tell when a user
is invisible without resorting to dirty hackery. In practice, this isn't a
problem, as you can still select the AIM user from the menu. And really, how
often will you be choosing the Invisible contact, rather than the user going
Invisible in the middle of a conversation or IMing you while they're Invisible?
JABBER NOTE:
This assumes that Jabber can always offline message. This isn't strictly true.
Sadrul said:
I have updated Jabber according to this link which seems to
talk about how to determine the existence offline-message
support in a server:
http://www.jabber.org/jeps/jep-0013.html#discover
However, jabber.org doesn't seem to send the required
info. So I am not sure about it.
He later said:
I talked to Nathan and he said offline message support is
mostly assumed for most jabber servers. GTalk doesn't yet
support it, but they are working on it. So I have made
jabber to always return TRUE.
If there is truly no way to detect offline messaging capability, then this is
an acceptable solution. We could special case Google Talk because of its
popularity, and remove that later. It's probably not worth it though.
MSN NOTE:
This assumes that MSN can never offline message. That's effectively true, but
to be technically correct, MSN can offline message if there's already a
switchboard conversation open with a user. We could write an offline_message
function in the MSN prpl to detect that, but it'd be of limited usefulness,
especially given that under most circumstances (where this might matter), the
switchboard connection will be closed almost immediately.
CVS NOTE:
I'm writing to share a tragic little story.
I have a PC that I use for Gaim development. One day, I was writing a commit
message on it, when all of a suddent it went berserk. The screen started
flashing, and the whole commit message just disappeared. All of it. And it was
a good commit message! I had to cram and rewrite it really quickly. Needless to
say, my rushed commit message wasn't nearly as good, and I blame the PC for that.
Seriously, though, what kind of version control system loses your commit
message on a broken connection to the server? Stupid!
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Fri, 23 Dec 2005 19:26:04 +0000 |
| parents | e346a085bb4f |
| children | cfc2f7fcb3dd |
line wrap: on
line source
/** * @file error.c Error functions * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "msn.h" #include "error.h" const char * msn_error_get_text(unsigned int type) { static char msg[MSN_BUF_LEN]; switch (type) { case 0: g_snprintf(msg, sizeof(msg), _("Unable to parse message")); case 200: g_snprintf(msg, sizeof(msg), _("Syntax Error (probably a Gaim bug)")); break; case 201: g_snprintf(msg, sizeof(msg), _("Invalid email address")); break; case 205: g_snprintf(msg, sizeof(msg), _("User does not exist")); break; case 206: g_snprintf(msg, sizeof(msg), _("Fully Qualified Domain Name missing")); break; case 207: g_snprintf(msg, sizeof(msg), _("Already Logged In")); break; case 208: g_snprintf(msg, sizeof(msg), _("Invalid Username")); break; case 209: g_snprintf(msg, sizeof(msg), _("Invalid Friendly Name")); break; case 210: g_snprintf(msg, sizeof(msg), _("List Full")); break; case 215: g_snprintf(msg, sizeof(msg), _("Already there")); break; case 216: g_snprintf(msg, sizeof(msg), _("Not on list")); break; case 217: g_snprintf(msg, sizeof(msg), _("User is offline")); break; case 218: g_snprintf(msg, sizeof(msg), _("Already in the mode")); break; case 219: g_snprintf(msg, sizeof(msg), _("Already in opposite list")); break; case 223: g_snprintf(msg, sizeof(msg), _("Too many groups")); break; case 224: g_snprintf(msg, sizeof(msg), _("Invalid group")); break; case 225: g_snprintf(msg, sizeof(msg), _("User not in group")); break; case 229: g_snprintf(msg, sizeof(msg), _("Group name too long")); break; case 230: g_snprintf(msg, sizeof(msg), _("Cannot remove group zero")); break; case 231: g_snprintf(msg, sizeof(msg), _("Tried to add a user to a group " "that doesn't exist")); break; case 280: g_snprintf(msg, sizeof(msg), _("Switchboard failed")); break; case 281: g_snprintf(msg, sizeof(msg), _("Notify Transfer failed")); break; case 300: g_snprintf(msg, sizeof(msg), _("Required fields missing")); break; case 301: g_snprintf(msg, sizeof(msg), _("Too many hits to a FND")); break; case 302: g_snprintf(msg, sizeof(msg), _("Not logged in")); break; case 500: g_snprintf(msg, sizeof(msg), _("Service Temporarily Unavailable")); break; case 501: g_snprintf(msg, sizeof(msg), _("Database server error")); break; case 502: g_snprintf(msg, sizeof(msg), _("Command disabled")); break; case 510: g_snprintf(msg, sizeof(msg), _("File operation error")); break; case 520: g_snprintf(msg, sizeof(msg), _("Memory allocation error")); break; case 540: g_snprintf(msg, sizeof(msg), _("Wrong CHL value sent to server")); break; case 600: g_snprintf(msg, sizeof(msg), _("Server busy")); break; case 601: g_snprintf(msg, sizeof(msg), _("Server unavailable")); break; case 602: g_snprintf(msg, sizeof(msg), _("Peer Notification server down")); break; case 603: g_snprintf(msg, sizeof(msg), _("Database connect error")); break; case 604: g_snprintf(msg, sizeof(msg), _("Server is going down (abandon ship)")); break; case 605: g_snprintf(msg, sizeof(msg), _("Server unavailable")); break; case 707: g_snprintf(msg, sizeof(msg), _("Error creating connection")); break; case 710: g_snprintf(msg, sizeof(msg), _("CVR parameters are either unknown or not allowed")); break; case 711: g_snprintf(msg, sizeof(msg), _("Unable to write")); break; case 712: g_snprintf(msg, sizeof(msg), _("Session overload")); break; case 713: g_snprintf(msg, sizeof(msg), _("User is too active")); break; case 714: g_snprintf(msg, sizeof(msg), _("Too many sessions")); break; case 715: g_snprintf(msg, sizeof(msg), _("Passport not verified")); break; case 717: g_snprintf(msg, sizeof(msg), _("Bad friend file")); break; case 731: g_snprintf(msg, sizeof(msg), _("Not expected")); break; case 800: g_snprintf(msg, sizeof(msg), _("Friendly name changes too rapidly")); break; case 910: case 912: case 918: case 919: case 921: case 922: g_snprintf(msg, sizeof(msg), _("Server too busy")); break; case 911: case 917: g_snprintf(msg, sizeof(msg), _("Authentication failed")); break; case 913: g_snprintf(msg, sizeof(msg), _("Not allowed when offline")); break; case 914: case 915: case 916: g_snprintf(msg, sizeof(msg), _("Server unavailable")); break; case 920: g_snprintf(msg, sizeof(msg), _("Not accepting new users")); break; case 923: g_snprintf(msg, sizeof(msg), _("Kids Passport without parental consent")); break; case 924: g_snprintf(msg, sizeof(msg), _("Passport account not yet verified")); break; case 928: g_snprintf(msg, sizeof(msg), _("Bad ticket")); break; default: g_snprintf(msg, sizeof(msg), _("Unknown Error Code %d"), type); break; } return msg; } void msn_error_handle(MsnSession *session, unsigned int type) { char buf[MSN_BUF_LEN]; g_snprintf(buf, sizeof(buf), _("MSN Error: %s\n"), msn_error_get_text(type)); gaim_notify_error(session->account->gc, NULL, buf, NULL); }
