Mercurial > pidgin
view src/protocols/icq/socketmanager.h @ 9550:de83d2cb87a4
[gaim-migrate @ 10379]
" When unqueuing messages and "sounds while away" is set,
Gaim will play a message receieved for every message
unqueued. If there are a large number of messages, my
SB Audigy tries playing them all and ends up creating a
crackly ugly sound. Friends of mine have complained
about this as well.
This patch fixes that by making sure sounds are
disabled when unqueuing messages. Sounds will be
re-enabled afterwards if necessary.
Something to note is that playing the sounds when
unqueuing messages crashes Gaim on occasion, with about
50% success. After applying this patch, the crashes
stopped. The backtrace isn't particularly
helpful...it's all question marks and valgrind doesn't
say much either. Crash or no crash though, this
eliminates annoying behavior so that is probably more
important.
I originally fixed this for my plugin AutoProfile, but
since they use similar code for queuing messages, it
would be nice if Gaim has it as well :)" --Casey Ho
committer: Tailor Script <tailor@pidgin.im>
| author | Luke Schierer <lschiere@pidgin.im> |
|---|---|
| date | Fri, 16 Jul 2004 14:56:47 +0000 |
| parents | 5e7ffea3f76a |
| children |
line wrap: on
line source
/* -*- Mode: C; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ /* * $Id: socketmanager.h 8967 2004-02-12 19:54:18Z hermanator $ * * Copyright (C) 1998-2001, Denis V. Dmitrienko <denis@null.net> and * Bill Soudan <soudan@kde.org> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. * */ #ifndef _SOCKETMANAGER_H #define _SOCKETMANAGER_H #ifdef HAVE_CONFIG_H #include <config.h> #endif #include <sys/types.h> #ifndef _WIN32 #include <sys/socket.h> #else #include "libc_interface.h" #endif #include "icq.h" #include "list.h" typedef struct icq_Socket_s icq_Socket; typedef void (*icq_SocketHandler)(void *data); struct icq_Socket_s { int socket; icq_SocketHandler handlers[ICQ_SOCKET_MAX]; void *data[ICQ_SOCKET_MAX]; }; int icq_SocketNew(int domain, int type, int protocol); int icq_SocketAccept(int listens, struct sockaddr *addr, int *addrlen); void icq_SocketAlloc(int socket_fd); int icq_SocketDelete(int socket_fd); void icq_SocketSetHandler(int socket_fd, int type, icq_SocketHandler handler, void *data); void icq_SocketReady(icq_Socket *s, int type); void icq_SocketBuildFdSets(void); void icq_SocketPoll(); icq_Socket *icq_FindSocket(int socket_fd); extern icq_List *icq_SocketList; #endif /* _SOCKETMANAGER_H */
