Mercurial > pidgin
view src/protocols/msn/command.c @ 8866:c2dff943e240
[gaim-migrate @ 9634]
(14:10:22) Faceprint: the timestamp plugin will now mislead users
(14:10:54) Me: which way does ichat behave?
(14:10:58) Me: i think the new way
(14:11:05) Me: but its been some time since i've seen it
(14:11:09) Faceprint: i don't know or care, the new behavior will confuse
the hell out of people
(14:11:22) Faceprint: lets say we have a conversation
(14:11:25) Faceprint: 2:00 gets printed by the plugin
(14:11:36) Faceprint: then we say nothing for 3 hours
(14:11:42) Faceprint: and then one of us says something
(14:12:04) Faceprint: that will be printed, and then as many as 5 minutes
later, the plugin will print 5:05
(14:12:23) Me: yes yes yes, i see both sides of this one. i tend to think
the new behavior is better, but i'll revert it
(14:12:36) Faceprint: since "normal" timestamps are turned off, it appears
as though what was just said was said around 2
(14:12:43) Faceprint: no, don't revert, fix
(14:12:53) Faceprint: preferably, make the patch writer fix
(14:12:57) Me: *nods*
(14:13:06) Me: which requires reverting since otherwise he won't be
motivated
(14:13:13) Faceprint: if something is said and we've gone more than 5 min
w/o printing a timestamp, print a timestamp before writing to the conv
committer: Tailor Script <tailor@pidgin.im>
| author | Luke Schierer <lschiere@pidgin.im> |
|---|---|
| date | Mon, 03 May 2004 18:13:39 +0000 |
| parents | a7affa2e2986 |
| children | 502707ca1836 |
line wrap: on
line source
/** * @file command.c MSN command functions * * gaim * * Copyright (C) 2003, Christian Hammond <chipx86@gnupdate.org> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "msn.h" #include "command.h" gboolean is_num(char *str) { char *c; for (c = str; *c; c++) { if (!(g_ascii_isdigit(*c))) return FALSE; } return TRUE; } MsnCommand * msn_command_from_string(const char *string) { MsnCommand *cmd; char *tmp; char *param_start; g_return_val_if_fail(string != NULL, NULL); tmp = g_strdup(string); param_start = strchr(tmp, ' '); cmd = g_new0(MsnCommand, 1); cmd->command = tmp; if (param_start) { char *param; int c; *param_start++ = '\0'; cmd->params = g_strsplit(param_start, " ", 0); for (c = 0; cmd->params[c]; c++); cmd->param_count = c; param = cmd->params[0]; cmd->trId = is_num(param) ? atoi(param) : 0; } else cmd->trId = 0; msn_command_ref(cmd); return cmd; } void msn_command_destroy(MsnCommand *cmd) { g_return_if_fail(cmd != NULL); if (cmd->ref_count > 0) { msn_command_unref(cmd); return; } g_free(cmd->command); g_strfreev(cmd->params); g_free(cmd); } MsnCommand * msn_command_ref(MsnCommand *cmd) { g_return_val_if_fail(cmd != NULL, NULL); cmd->ref_count++; return cmd; } MsnCommand * msn_command_unref(MsnCommand *cmd) { g_return_val_if_fail(cmd != NULL, NULL); if (cmd->ref_count <= 0) return NULL; cmd->ref_count--; if (cmd->ref_count == 0) { msn_command_destroy(cmd); return NULL; } return cmd; }
