Mercurial > pidgin
view src/debug.h @ 7667:30593bf56e71
[gaim-migrate @ 8311]
(23:56:25) shx: LSchiere: there's something wrong in my patch
(23:56:34) Luke: okay
(23:56:38) Luke: what's that
(23:57:45) shx: I forgot to add a '0' a the end of a string
(23:57:56) shx: in the gaim_mime_decode_field funcition
(23:59:35) Luke: where in that?
(00:00:16) shx: at the end, just before this
(00:00:18) shx: if (*unencoded_start)
(00:00:19) shx: n = strcpy(n, unencoded_start);
(00:00:27) shx: whould be this
(00:00:28) shx: *n = '\0';
(00:01:05) Luke: so you are just setting it to NULL
(00:01:53) Luke: i don't understand why you need that n set at all inside
that if, since you just return new on the next line down
(00:03:35) shx: I doing some test right now, but I remember I added that
because I had of some errors
(00:05:04) Luke: i think what you may be hitting is a functional work
around for not properly initializing variables, something that shouldn't
work but does. because you shouldn't need to set something just before you
return unless you are returning IT (or unless you are using staticly
declared memory, in which case you might concievably be using that variable
again when you next enter the function
(00:05:55) shx: no
(00:06:18) shx: n is a pointer to the end of the string, and changes as the
while goes on
(00:06:37) Luke: ah
(00:06:42) shx: n doesn't matter
(00:07:01) Luke: so should the *n = '\0' be inside the if or outside it?
(00:07:30) shx: before the if
(00:07:44) shx: *n = '\0';
(00:07:45) shx: if (*unencoded_start)
(00:07:45) shx: n = strcpy(n, unencoded_start);
(00:08:07) shx: in the case there is no *unencoded_start
committer: Tailor Script <tailor@pidgin.im>
| author | Luke Schierer <lschiere@pidgin.im> |
|---|---|
| date | Sun, 30 Nov 2003 05:10:24 +0000 |
| parents | feb3d21a7794 |
| children | fa6395637e2c |
line wrap: on
line source
/** * @file debug.h Debug API * @ingroup core * * gaim * * Copyright (C) 2002-2003, Christian Hammond <chipx86@gnupdate.org> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #ifndef _GAIM_DEBUG_H_ #define _GAIM_DEBUG_H_ #include <stdarg.h> /** * Debug levels. */ typedef enum { GAIM_DEBUG_ALL = 0, /**< All debug levels. */ GAIM_DEBUG_MISC, /**< General chatter. */ GAIM_DEBUG_INFO, /**< General operation Information. */ GAIM_DEBUG_WARNING, /**< Warnings. */ GAIM_DEBUG_ERROR, /**< Errors. */ GAIM_DEBUG_FATAL /**< Fatal errors. */ } GaimDebugLevel; /** * Debug UI operations. */ typedef struct { void (*print)(GaimDebugLevel level, const char *category, const char *format, va_list args); } GaimDebugUiOps; #ifdef __cplusplus extern "C" { #endif /**************************************************************************/ /** @name Debug API */ /**************************************************************************/ /** * Outputs debug information. * * This differs from gaim_debug() in that it takes a va_list. * * @param level The debug level. * @param category The category (or @c NULL). * @param format The format string. * @param args The format parameters. * * @see gaim_debug() */ void gaim_debug_vargs(GaimDebugLevel level, const char *category, const char *format, va_list args); /** * Outputs debug information. * * @param level The debug level. * @param category The category (or @c NULL). * @param format The format string. */ void gaim_debug(GaimDebugLevel level, const char *category, const char *format, ...); /** * Outputs misc. level debug information. * * This is a wrapper for gaim_debug(), and uses GAIM_DEBUG_MISC as * the level. * * @param category The category (or @c NULL). * @param format The format string. * * @see gaim_debug() */ void gaim_debug_misc(const char *category, const char *format, ...); /** * Outputs info level debug information. * * This is a wrapper for gaim_debug(), and uses GAIM_DEBUG_INFO as * the level. * * @param category The category (or @c NULL). * @param format The format string. * * @see gaim_debug() */ void gaim_debug_info(const char *category, const char *format, ...); /** * Outputs warning level debug information. * * This is a wrapper for gaim_debug(), and uses GAIM_DEBUG_WARNING as * the level. * * @param category The category (or @c NULL). * @param format The format string. * * @see gaim_debug() */ void gaim_debug_warning(const char *category, const char *format, ...); /** * Outputs error level debug information. * * This is a wrapper for gaim_debug(), and uses GAIM_DEBUG_ERROR as * the level. * * @param category The category (or @c NULL). * @param format The format string. * * @see gaim_debug() */ void gaim_debug_error(const char *category, const char *format, ...); /** * Outputs fatal error level debug information. * * This is a wrapper for gaim_debug(), and uses GAIM_DEBUG_ERROR as * the level. * * @param category The category (or @c NULL). * @param format The format string. * * @see gaim_debug() */ void gaim_debug_fatal(const char *category, const char *format, ...); /*@}*/ /**************************************************************************/ /** @name UI Registration Functions */ /**************************************************************************/ /*@{*/ /** * Sets the UI operations structure to be used when outputting debug * information. * * @param ops The UI operations structure. */ void gaim_debug_set_ui_ops(GaimDebugUiOps *ops); /** * Returns the UI operations structure used when outputting debug * information. * * @return The UI operations structure in use. */ GaimDebugUiOps *gaim_debug_get_ui_ops(void); /*@}*/ #ifdef __cplusplus } #endif #endif /* _GAIM_DEBUG_H_ */
