Mercurial > pidgin

diff libpurple/protocols/msn/httpconn.c @ 31646:d732689006ed

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fix a potential null pointer dereference in the MSN protocol, discovered by Marius Wachtler and reported to security@pidgin.im on March 22nd. This one is kinda rare, and requires someone to perform a man-in-the-middle attack in order to cause the crash. So we're not going to go through the CVE process for it (at least... probably not).
author Mark Doliner <mark@kingant.net>
date Tue, 07 Jun 2011 08:13:59 +0000
parents 72e6fa6caecc
children b6955681b7b3
line wrap: on
line diff
--- a/libpurple/protocols/msn/httpconn.c	Tue Jun 07 07:42:56 2011 +0000
+++ b/libpurple/protocols/msn/httpconn.c	Tue Jun 07 08:13:59 2011 +0000
@@ -217,7 +217,7 @@
 
 		g_free(tmp);
 
-		t = strchr(full_session_id, '.');
+		t = full_session_id ? strchr(full_session_id, '.') : NULL;
 		if (t != NULL)
 			session_id = g_strndup(full_session_id, t - full_session_id);
 		else {