diff src/away.c @ 4167:7002b6f16bdf

[gaim-migrate @ 4396] (00:14:20) Robot101: if anyone with CVS would like to choose between the docklet eating messages if you ask it to queue them, or an occasional crash when returning from away with queued messages, I have a patch to revert ari's 'fix' at http://people.debian.org/~robot101/silly-ari.diff (00:15:05) Robot101: Sean and I agreed that keeping the queued messages in a GSList is better, so if ari could seperate the gtk2ification and the fixing of the crash, without breaking the generic queueing stuff, that'd be peachy (00:15:22) Robot101: in the meantime, the docklet saying it has queued messages, and not letting you read them, is pretty damn obnoxious. (00:16:30) LSchiere: i'll do it committer: Tailor Script <[e-mail]>

--- a/src/away.c	Thu Jan 02 01:18:21 2003 +0000
+++ b/src/away.c	Thu Jan 02 05:18:16 2003 +0000
@@ -36,9 +36,8 @@
 GtkWidget *imaway = NULL;
 
 GtkWidget *awaymenu = NULL;
-GtkWidget *awayqueue = NULL;
-GtkListStore *awayqueuestore;
-GtkWidget *awayqueuesw;
+GtkWidget *clistqueue = NULL;
+GtkWidget *clistqueuesw;
 
 struct away_message *awaymessage = NULL;
 struct away_message *default_away;
@@ -49,24 +48,53 @@
 	if (imaway)
 		gtk_widget_destroy(imaway);
 
-	awayqueue = NULL;
-	awayqueuestore = NULL;
-	awayqueuesw = NULL;
+	clistqueue = NULL;
+	clistqueuesw = NULL;
 	imaway = NULL;
 }
 
-void dequeue_message(GtkTreeIter *iter)
+void purge_away_queue(GSList *queue)
 {
-	gchar *name;
-	GSList *templist;
 	struct conversation *cnv;
 
-	gtk_tree_model_get(GTK_TREE_MODEL(awayqueuestore), iter, 0, &name, -1);
+	gtk_clist_freeze(GTK_CLIST(clistqueue));
+	gtk_clist_clear(GTK_CLIST(clistqueue));
+
+	while (queue) {
+		struct queued_message *qm = queue->data;
+
+		cnv = find_conversation(qm->name);
+		if (!cnv)
+			cnv = new_conversation(qm->name);
+		if (g_slist_index(connections, qm->gc) >= 0)
+			set_convo_gc(cnv, qm->gc);
+		write_to_conv(cnv, qm->message, qm->flags, NULL, qm->tm, qm->len);
+
+		queue = g_slist_remove(queue, qm);
+
+		g_free(qm->message);
+		g_free(qm);
+	}
+
+	gtk_clist_thaw(GTK_CLIST(clistqueue));
+}
+
+void dequeue_by_buddy(GtkWidget *clist, gint row, gint column, GdkEventButton *event, gpointer data) {
+	char *temp;
+	char *name;
+	GSList *templist;
+	struct conversation *cnv;
 	
+	if(!(event->type == GDK_2BUTTON_PRESS && event->button == 1))
+		return; /* Double clicking on the clist will unqueue that users messages. */
+	
+	gtk_clist_get_text(GTK_CLIST(clist), row, 0, &temp);
+	name = g_strdup(temp);
+
+	if (!name)
+		return;
 	debug_printf("Unqueueing messages from %s.\n", name);
-	
 	templist = message_queue;
-	
 	while (templist) {
 		struct queued_message *qm = templist->data;
 		if (templist->data) {
@@ -87,55 +115,25 @@
 			}
 		}
 	}
-	
 	g_free(name);
-	/* In GTK 2.2, _store_remove actually returns whether iter is valid or not
-	 * after the remove, but in GTK 2.0 it is a void function. */
-	gtk_list_store_remove(awayqueuestore, iter);
-}
-
-void purge_away_queue(GSList *queue)
-{
-	gboolean valid;
-	GtkTreeIter iter;
+	gtk_clist_remove(GTK_CLIST(clist), row);
 
-	valid = gtk_tree_model_get_iter_first(GTK_TREE_MODEL(awayqueuestore), &iter);
-	while(valid) {
-		dequeue_message(&iter);
-		valid = gtk_tree_model_get_iter_first(GTK_TREE_MODEL(awayqueuestore),
-				&iter);
-	}	
+}
 	
-	g_object_unref(G_OBJECT(awayqueuestore));
-}
-
-gint dequeue_cb(GtkWidget *treeview, GdkEventButton *event, gpointer data) {
-	GtkTreeIter iter;
-	GtkTreeSelection *select;
-	
-	if(!(event->type == GDK_2BUTTON_PRESS && event->button == 1))
-		return FALSE; /* Double clicking on the list will unqueue that user's messages. */
-	
-	select = gtk_tree_view_get_selection(GTK_TREE_VIEW(treeview));
-	if(gtk_tree_selection_get_selected(select, NULL, &iter))
-			dequeue_message(&iter);
-
-	return FALSE;
-}
 	
 
 
 void toggle_away_queue()
 {
-	if (!awayqueue || !awayqueuesw)
+	if (!clistqueue || !clistqueuesw)
 		return;
 
 	if (away_options & OPT_AWAY_QUEUE) {
-		gtk_widget_show(awayqueue);
-		gtk_widget_show(awayqueuesw);
+		gtk_widget_show(clistqueue);
+		gtk_widget_show(clistqueuesw);
 	} else {
-		gtk_widget_hide(awayqueue);
-		gtk_widget_hide(awayqueuesw);
+		gtk_widget_hide(clistqueue);
+		gtk_widget_hide(clistqueuesw);
 		purge_away_queue(message_queue);
 	}
 }
@@ -160,8 +158,8 @@
 	}
 
 	awaymessage = NULL;
-	awayqueue = NULL;
-	awayqueuesw = NULL;
+	clistqueue = NULL;
+	clistqueuesw = NULL;
 	serv_set_away_all(NULL);
 }
 
@@ -172,8 +170,6 @@
 	GtkWidget *awaytext;
 	GtkWidget *sw;
 	GtkWidget *vbox;
-	GtkTreeViewColumn *column;
-	GtkCellRenderer *renderer;
 	char *buf2;
 	char *buf;
 
@@ -218,35 +214,22 @@
 		gtk_imhtml_append_text(GTK_IMHTML(awaytext), "<BR>", -1, GTK_IMHTML_NO_TITLE |
 				       GTK_IMHTML_NO_COMMENTS | GTK_IMHTML_NO_SCROLL);
 
-		awayqueuesw = gtk_scrolled_window_new(NULL, NULL);
-		gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(awayqueuesw), GTK_POLICY_NEVER,
+		clistqueuesw = gtk_scrolled_window_new(NULL, NULL);
+		gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(clistqueuesw), GTK_POLICY_NEVER,
 					       GTK_POLICY_AUTOMATIC);
-		gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(awayqueuesw),
-							GTK_SHADOW_IN);
-		gtk_box_pack_start(GTK_BOX(vbox), awayqueuesw, TRUE, TRUE, 0);
+		gtk_box_pack_start(GTK_BOX(vbox), clistqueuesw, TRUE, TRUE, 0);
 
-		awayqueuestore = gtk_list_store_new(2, G_TYPE_STRING, G_TYPE_STRING);
-		awayqueue = gtk_tree_view_new_with_model(GTK_TREE_MODEL(awayqueuestore));
-		renderer = gtk_cell_renderer_text_new();
-		
-		gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(awayqueue), FALSE);
-		column = gtk_tree_view_column_new_with_attributes (NULL, renderer,
-										"text", 0,
-										NULL);
-		gtk_tree_view_append_column(GTK_TREE_VIEW(awayqueue), column);
-		column = gtk_tree_view_column_new_with_attributes(NULL, renderer,
-										"text", 1, 
-										NULL);
-		gtk_tree_view_append_column(GTK_TREE_VIEW(awayqueue), column);
-			
-		gtk_container_add(GTK_CONTAINER(awayqueuesw), awayqueue);
-		
-		g_signal_connect(G_OBJECT(awayqueue), "button_press_event", G_CALLBACK(dequeue_cb), NULL);
+		clistqueue = gtk_clist_new(2);
+		gtk_clist_set_column_width(GTK_CLIST(clistqueue), 0, 100);
+		gtk_widget_set_usize(GTK_WIDGET(clistqueue), -1, 50);
+		gtk_container_add(GTK_CONTAINER(clistqueuesw), clistqueue);
+		gtk_signal_connect(GTK_OBJECT(clistqueue), "select_row", GTK_SIGNAL_FUNC(dequeue_by_buddy), NULL);
+
 
 
 		if (away_options & OPT_AWAY_QUEUE) {
-			gtk_widget_show(awayqueuesw);
-			gtk_widget_show(awayqueue);
+			gtk_widget_show(clistqueuesw);
+			gtk_widget_show(clistqueue);
 		}
 
 		back = picture_button(imaway, _("I'm Back!"), join_xpm);