Mercurial > pidgin
comparison src/protocols/silc/ops.c @ 9927:fb08a0973b3e
[gaim-migrate @ 10819]
" Currently, the "loggedin" parameter of
serv_got_update() is of type int and used as a boolean.
I updated it and all references to be gboolean.
I also noticed that "presence" in
gaim_blist_update_buddy_presence() is also a really
boolean. of whether or not the buddy is currently
online. There seemed to be some confusion,
particularly in the silc plugin which tried to use a
GaimBuddyPresenceState (coincidentally (or perhaps not)
GAIM_BUDDY_OFFLINE and GAIM_BUDDY_ONLINE work as FALSE
and TRUE respectively). The value passed to
gaim_blist_update_buddy_presence() doesn't directly
become the buddy presence state and this patch helps
avoid confusion in this respect." --Daniel Atallah
committer: Tailor Script <tailor@pidgin.im>
| author | Luke Schierer <lschiere@pidgin.im> |
|---|---|
| date | Wed, 01 Sep 2004 01:07:42 +0000 |
| parents | c28d5b45624e |
| children | 0f5ad31051a0 |
comparison
equal
deleted
inserted
replaced
| 9926:b23e70bd1215 | 9927:fb08a0973b3e |
|---|---|
| 706 client_entry->mode & SILC_UMODE_INDISPOSED || | 706 client_entry->mode & SILC_UMODE_INDISPOSED || |
| 707 client_entry->mode & SILC_UMODE_BUSY || | 707 client_entry->mode & SILC_UMODE_BUSY || |
| 708 client_entry->mode & SILC_UMODE_PAGE || | 708 client_entry->mode & SILC_UMODE_PAGE || |
| 709 client_entry->mode & SILC_UMODE_DETACHED)) { | 709 client_entry->mode & SILC_UMODE_DETACHED)) { |
| 710 client_entry->mode = mode; | 710 client_entry->mode = mode; |
| 711 gaim_blist_update_buddy_presence(b, GAIM_BUDDY_ONLINE); | 711 gaim_blist_update_buddy_presence(b, TRUE); |
| 712 } | 712 } |
| 713 else if ((mode & SILC_UMODE_GONE) || | 713 else if ((mode & SILC_UMODE_GONE) || |
| 714 (mode & SILC_UMODE_INDISPOSED) || | 714 (mode & SILC_UMODE_INDISPOSED) || |
| 715 (mode & SILC_UMODE_BUSY) || | 715 (mode & SILC_UMODE_BUSY) || |
| 716 (mode & SILC_UMODE_PAGE) || | 716 (mode & SILC_UMODE_PAGE) || |
| 717 (mode & SILC_UMODE_DETACHED)) { | 717 (mode & SILC_UMODE_DETACHED)) { |
| 718 client_entry->mode = mode; | 718 client_entry->mode = mode; |
| 719 gaim_blist_update_buddy_presence(b, GAIM_BUDDY_OFFLINE); | 719 gaim_blist_update_buddy_presence(b, FALSE); |
| 720 } | 720 } |
| 721 } else if (notify == SILC_NOTIFY_TYPE_SIGNOFF || | 721 } else if (notify == SILC_NOTIFY_TYPE_SIGNOFF || |
| 722 notify == SILC_NOTIFY_TYPE_SERVER_SIGNOFF || | 722 notify == SILC_NOTIFY_TYPE_SERVER_SIGNOFF || |
| 723 notify == SILC_NOTIFY_TYPE_KILLED) { | 723 notify == SILC_NOTIFY_TYPE_KILLED) { |
| 724 client_entry->mode = mode; | 724 client_entry->mode = mode; |
| 725 gaim_blist_update_buddy_presence(b, GAIM_BUDDY_OFFLINE); | 725 gaim_blist_update_buddy_presence(b, FALSE); |
| 726 } else if (notify == SILC_NOTIFY_TYPE_NONE) { | 726 } else if (notify == SILC_NOTIFY_TYPE_NONE) { |
| 727 client_entry->mode = mode; | 727 client_entry->mode = mode; |
| 728 gaim_blist_update_buddy_presence(b, GAIM_BUDDY_ONLINE); | 728 gaim_blist_update_buddy_presence(b, TRUE); |
| 729 } | 729 } |
| 730 } | 730 } |
| 731 break; | 731 break; |
| 732 | 732 |
| 733 default: | 733 default: |