Mercurial > pidgin
comparison src/blist.c @ 9969:cc2e6dd43613
[gaim-migrate @ 10879]
(21:35:19) nosnilmot: LSchiere: gaim_blist_add_group() should not really be
#if 0'd out... does that need a patch?
(21:35:38) LSchiere: why is it #if 0'ed?
(21:35:50) nosnilmot: merging error afaict
(21:35:52) interalia: datallah: talking to yourself is OK. it's when you
answer that it becomes a problem...
(21:35:54) LSchiere: i'm assuming it was done for a reason, temporary as
that reason might be
(21:36:04) nosnilmot: it's not #if 0'd in chip's svn tree
(21:36:08) LSchiere: oddness
(21:36:16) interalia: cvs annotate to the rescue!
(21:36:23) LSchiere: was that part of datallah's patch failure handle
patch?
(21:36:49) datallah: yeah... i'm confused as to how it happened, but the
first part happened during the plain merge and the #endif i added during
the .rej cleanup iirc
(21:37:31) nosnilmot: yup, datallah's right :) I suspect the #if 0 came in
because "patch" was trying to "help"
(21:37:47) LSchiere: okay, let's see what happens without that
(21:38:11) nosnilmot: "it works a lot better and doesn't eat as many buddy
lists for breakfast"
(21:38:12) datallah: it definitely needs to not be commented out
it compiles uncommented, so we'll go with their opinion
committer: Tailor Script <tailor@pidgin.im>
| author | Luke Schierer <lschiere@pidgin.im> |
|---|---|
| date | Wed, 08 Sep 2004 01:38:38 +0000 |
| parents | ced29c7b396c |
| children | 4d2269c6c673 |
comparison
equal
deleted
inserted
replaced
| 9968:67468d443cd1 | 9969:cc2e6dd43613 |
|---|---|
| 1114 } | 1114 } |
| 1115 } | 1115 } |
| 1116 | 1116 |
| 1117 void gaim_blist_add_group(GaimGroup *group, GaimBlistNode *node) | 1117 void gaim_blist_add_group(GaimGroup *group, GaimBlistNode *node) |
| 1118 { | 1118 { |
| 1119 #if 0 | |
| 1120 GaimBlistUiOps *ops; | 1119 GaimBlistUiOps *ops; |
| 1121 GaimBlistNode *gnode = (GaimBlistNode*)group; | 1120 GaimBlistNode *gnode = (GaimBlistNode*)group; |
| 1122 | 1121 |
| 1123 g_return_if_fail(group != NULL); | 1122 g_return_if_fail(group != NULL); |
| 1124 g_return_if_fail(GAIM_BLIST_NODE_IS_GROUP((GaimBlistNode *)group)); | 1123 g_return_if_fail(GAIM_BLIST_NODE_IS_GROUP((GaimBlistNode *)group)); |
| 1166 if (ops && ops->update) { | 1165 if (ops && ops->update) { |
| 1167 ops->update(gaimbuddylist, gnode); | 1166 ops->update(gaimbuddylist, gnode); |
| 1168 for (node = gnode->child; node; node = node->next) | 1167 for (node = gnode->child; node; node = node->next) |
| 1169 ops->update(gaimbuddylist, node); | 1168 ops->update(gaimbuddylist, node); |
| 1170 } | 1169 } |
| 1171 #endif | |
| 1172 } | 1170 } |
| 1173 | 1171 |
| 1174 void gaim_blist_remove_contact(GaimContact *contact) | 1172 void gaim_blist_remove_contact(GaimContact *contact) |
| 1175 { | 1173 { |
| 1176 GaimBlistUiOps *ops = gaimbuddylist->ui_ops; | 1174 GaimBlistUiOps *ops = gaimbuddylist->ui_ops; |
