Mercurial > pidgin
comparison src/proxy.c @ 5970:730015652f4d
[gaim-migrate @ 6417]
Fixes one of those GDK warning things. Happened when clicking cancel on
select font dialog for conversations. Problem was gtk_widget_destroy was
getting called twice for gtkconv->dialogs.font, second time being passed
NULL.
This font stuff is ugly, IMHO. Like, look at show_font_dialog. Yeesh.
No code re-use whatsoever. That function should either be split up or
made to suck less. One of gai'ms young aspiring actors should take care
of that. Aren't there always people that are like, "I want to code something
but don't know what to do?!??" Well there you go.
I also changed a bit o' proxy.c code in an attempt to fix KimuSan^'s
problem. I'm not really sure what his problem is, but I have a strong
feeling that the lines I changed are better the way they are now. If
I'm wrong, someone should probably correct me. But if I'm right... we'll
lets just say we'll all be a whole lot thinner.
"And somebody get this walking carpet out of my way."
"No reward is worth this."
committer: Tailor Script <tailor@pidgin.im>
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Sat, 28 Jun 2003 17:15:23 +0000 |
| parents | 059d95c67cda |
| children | 5e9364e9b29e |
comparison
equal
deleted
inserted
replaced
| 5969:4b1d6ed1204f | 5970:730015652f4d |
|---|---|
| 735 no_one_calls(gpointer data, gint source, GaimInputCondition cond) | 735 no_one_calls(gpointer data, gint source, GaimInputCondition cond) |
| 736 { | 736 { |
| 737 struct PHB *phb = data; | 737 struct PHB *phb = data; |
| 738 unsigned int len; | 738 unsigned int len; |
| 739 int error=0; | 739 int error=0; |
| 740 int ret=0; | |
| 741 | 740 |
| 742 gaim_debug(GAIM_DEBUG_INFO, "proxy", "Connected.\n"); | 741 gaim_debug(GAIM_DEBUG_INFO, "proxy", "Connected.\n"); |
| 743 | 742 |
| 744 len = sizeof(error); | 743 len = sizeof(error); |
| 745 | 744 |
| 746 ret = getsockopt(source, SOL_SOCKET, SO_ERROR, &error, &len); | 745 if (getsockopt(source, SOL_SOCKET, SO_ERROR, &error, &len) < 0) { |
| 747 if (ret < 0 || error != 0) { | 746 /* if (ret < 0 || error != 0) { */ |
| 748 if(ret==0) errno = error; | 747 /* The fourth parameter above isn't really "error", is it? */ |
| 748 /* if(ret==0) errno = error; */ | |
| 749 close(source); | 749 close(source); |
| 750 gaim_input_remove(phb->inpa); | 750 gaim_input_remove(phb->inpa); |
| 751 | 751 |
| 752 if (phb->account == NULL || | 752 if (phb->account == NULL || |
| 753 gaim_account_get_connection(phb->account) != NULL) { | 753 gaim_account_get_connection(phb->account) != NULL) { |
