comparison libpurple/plugins/log_reader.c @ 17531:21773944db4b

Don't create the temp GString unless it's actually needed, and avoid doing an strlen() there unless that's really needed.

17530:a6594c34635b

	line = read;
	while (c)
	{
		const char *link;
		const char *footer = NULL;
		GString *temp;

		c = strstr(c, "\n");

		if (c) {
			*c = '\0';
			++c;
		}

		/* Convert links.
		 *
		 * The format is (Link: URL)URL

		 * Then, replace the next " " (or add this if the end-of-line is reached) with:
		 * </a>
		 * 
		 * As implemented, this isn't perfect, but it should cover common cases.
		 */
		temp = g_string_sized_new(strlen(line));
		while (line && (link = strstr(line, "(Link: ")))
		{
			const char *tmp = link;

			link += 7;

				if (!(end_paren = strstr(link, ")")))
				{
					/* Something is not as we expect.  Bail out. */
					break;
				}

				g_string_append_len(temp, line, (tmp - line));

				/* Start an <a> tag. */
				g_string_append(temp, "<a href=\"");

				/* Something is not as we expect.  Bail out. */
				break;
			}
		}

		if (line) {
			g_string_append(temp, line);
		}
		line = temp->str;

		if (*line == '[') {
			const char *timestamp;

			if ((timestamp = strstr(line, "]"))) {

			}
		}

		g_string_append(formatted, line);

		if (footer)
			g_string_append(formatted, footer);

		g_string_append_c(formatted, '\n');

		g_string_free(temp, TRUE);

		line = c;
	}

	g_free(read);
	read = formatted->str;
	g_string_free(formatted, FALSE);

	return read;
}

static int trillian_logger_size (PurpleLog *log)
{
	struct trillian_logger_data *data;

17531:21773944db4b

	line = read;
	while (c)
	{
		const char *link;
		const char *footer = NULL;
		GString *temp = NULL;

		if ((c = strstr(c, "\n")))
		{
			*c = '\0';
			c++;
		}

		/* Convert links.
		 *
		 * The format is (Link: URL)URL

		 * Then, replace the next " " (or add this if the end-of-line is reached) with:
		 * </a>
		 * 
		 * As implemented, this isn't perfect, but it should cover common cases.
		 */
		while (line && (link = strstr(line, "(Link: ")))
		{
			const char *tmp = link;

			link += 7;

				if (!(end_paren = strstr(link, ")")))
				{
					/* Something is not as we expect.  Bail out. */
					break;
				}

				if (!temp)
					temp = g_string_sized_new(c ? (c - 1 - line) : strlen(line));

				g_string_append_len(temp, line, (tmp - line));

				/* Start an <a> tag. */
				g_string_append(temp, "<a href=\"");

				/* Something is not as we expect.  Bail out. */
				break;
			}
		}

		if (temp)
		{
			if (line)
				g_string_append(temp, line);
			line = temp->str;
		}

		if (*line == '[') {
			const char *timestamp;

			if ((timestamp = strstr(line, "]"))) {

			}
		}

		g_string_append(formatted, line);

		line = c;
		if (temp)
			g_string_free(temp, TRUE);

		if (footer)
			g_string_append(formatted, footer);

		g_string_append_c(formatted, '\n');
	}

	g_free(read);
	/* XXX: TODO: Avoid this g_strchomp() */
	return g_strchomp(g_string_free(formatted, FALSE));
}

static int trillian_logger_size (PurpleLog *log)
{
	struct trillian_logger_data *data;