Mercurial > pidgin
annotate src/protocols/msn/slpmsg.c @ 12645:fc28451f5d96
[gaim-migrate @ 14983]
SF Patch #1314512 from Sadrul (who has a patch for everything)
"This patch introduces a flag for protocol plugins that
support offline messages (like Y!M and ICQ). This was
encouraged by the following conversation:
<sadrul> should offline buddies be listed/enabled in
the send-to menu?
<rekkanoryo> i would think only for protocols that
support offline messaging, if it's indicated that the
buddy is offline
-- <snip> --
<Bleeter> sadrul: personally, I'd like to see a
'supports offline' flag of some description
<Bleeter> one could then redirect (via plugins) through
email or alternative methods
<Bleeter> just a thought
<Paco-Paco> yeah, that sounds like a reasonble thing to have
This patch uses this flag to disable the buddies in the
send-to menu who are offline and the protocol doesn't
support offline messages."
I made this make the label insensitive instead of the whole menuitem. This
should address SimGuy's concerns about inconsistency (i.e. you could create a
conversation with someone via the buddy list that you couldn't create via the
Send To menu). I also hacked up some voodoo to show the label as sensitive when
moused-over, as that looks better (given the label-insensitive thing is itself a
hack). I think this works quite well.
BUG NOTE:
This makes more obvious an existing bug. The Send To menu isn't updated when
buddies sign on or off or change status (at least under some circumstances).
We need to fix that anyway, so I'm not going to let it hold up this commit.
Switching tabs will clear it up. I'm thinking we just might want to build the
contents of that menu when it is selected. That would save us a mess of
inefficient signal callbacks that update the Send To menus in open windows all
the time.
AIM NOTE:
This assumes that AIM can't offline message. That's not strictly true. You can
message invisible users on AIM. However, by design, we can't tell when a user
is invisible without resorting to dirty hackery. In practice, this isn't a
problem, as you can still select the AIM user from the menu. And really, how
often will you be choosing the Invisible contact, rather than the user going
Invisible in the middle of a conversation or IMing you while they're Invisible?
JABBER NOTE:
This assumes that Jabber can always offline message. This isn't strictly true.
Sadrul said:
I have updated Jabber according to this link which seems to
talk about how to determine the existence offline-message
support in a server:
http://www.jabber.org/jeps/jep-0013.html#discover
However, jabber.org doesn't seem to send the required
info. So I am not sure about it.
He later said:
I talked to Nathan and he said offline message support is
mostly assumed for most jabber servers. GTalk doesn't yet
support it, but they are working on it. So I have made
jabber to always return TRUE.
If there is truly no way to detect offline messaging capability, then this is
an acceptable solution. We could special case Google Talk because of its
popularity, and remove that later. It's probably not worth it though.
MSN NOTE:
This assumes that MSN can never offline message. That's effectively true, but
to be technically correct, MSN can offline message if there's already a
switchboard conversation open with a user. We could write an offline_message
function in the MSN prpl to detect that, but it'd be of limited usefulness,
especially given that under most circumstances (where this might matter), the
switchboard connection will be closed almost immediately.
CVS NOTE:
I'm writing to share a tragic little story.
I have a PC that I use for Gaim development. One day, I was writing a commit
message on it, when all of a suddent it went berserk. The screen started
flashing, and the whole commit message just disappeared. All of it. And it was
a good commit message! I had to cram and rewrite it really quickly. Needless to
say, my rushed commit message wasn't nearly as good, and I blame the PC for that.
Seriously, though, what kind of version control system loses your commit
message on a broken connection to the server? Stupid!
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Fri, 23 Dec 2005 19:26:04 +0000 |
| parents | 95fa774d216d |
| children |
| rev | line source |
|---|---|
| 9193 | 1 /** |
| 2 * @file slpmsg.h SLP Message functions | |
| 3 * | |
| 4 * gaim | |
| 5 * | |
|
9198
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
6 * Gaim is the legal property of its developers, whose names are too numerous |
|
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
7 * to list here. Please refer to the COPYRIGHT file distributed with this |
|
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
8 * source distribution. |
|
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
9 * |
| 9193 | 10 * This program is free software; you can redistribute it and/or modify |
| 11 * it under the terms of the GNU General Public License as published by | |
| 12 * the Free Software Foundation; either version 2 of the License, or | |
| 13 * (at your option) any later version. | |
| 14 * | |
| 15 * This program is distributed in the hope that it will be useful, | |
| 16 * but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 17 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
| 18 * GNU General Public License for more details. | |
| 19 * | |
| 20 * You should have received a copy of the GNU General Public License | |
| 21 * along with this program; if not, write to the Free Software | |
| 22 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | |
| 23 */ | |
| 24 #include "msn.h" | |
| 25 #include "slpmsg.h" | |
| 26 #include "slplink.h" | |
| 27 | |
| 28 /************************************************************************** | |
| 29 * SLP Message | |
| 30 **************************************************************************/ | |
| 31 | |
| 32 MsnSlpMessage * | |
| 33 msn_slpmsg_new(MsnSlpLink *slplink) | |
| 34 { | |
| 35 MsnSlpMessage *slpmsg; | |
| 10345 | 36 |
| 9193 | 37 slpmsg = g_new0(MsnSlpMessage, 1); |
| 38 | |
| 10345 | 39 #ifdef MSN_DEBUG_SLPMSG |
| 40 gaim_debug_info("msn", "slpmsg new (%p)\n", slpmsg); | |
| 41 #endif | |
| 42 | |
| 9193 | 43 slpmsg->slplink = slplink; |
| 44 | |
| 45 slplink->slp_msgs = | |
| 46 g_list_append(slplink->slp_msgs, slpmsg); | |
| 47 | |
| 48 return slpmsg; | |
| 49 } | |
| 50 | |
| 51 void | |
| 52 msn_slpmsg_destroy(MsnSlpMessage *slpmsg) | |
| 53 { | |
| 54 MsnSlpLink *slplink; | |
| 10345 | 55 GList *cur; |
| 56 | |
| 57 g_return_if_fail(slpmsg != NULL); | |
| 58 | |
| 59 #ifdef MSN_DEBUG_SLPMSG | |
| 60 gaim_debug_info("msn", "slpmsg destroy (%p)\n", slpmsg); | |
| 61 #endif | |
| 9193 | 62 |
| 63 slplink = slpmsg->slplink; | |
| 64 | |
| 65 if (slpmsg->fp != NULL) | |
| 66 fclose(slpmsg->fp); | |
|
9198
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
67 |
| 9193 | 68 if (slpmsg->buffer != NULL) |
| 69 g_free(slpmsg->buffer); | |
| 70 | |
| 10345 | 71 #ifdef MSN_DEBUG_SLP |
| 9193 | 72 /* |
| 73 if (slpmsg->info != NULL) | |
| 74 g_free(slpmsg->info); | |
| 75 */ | |
| 76 #endif | |
| 77 | |
| 10345 | 78 for (cur = slpmsg->msgs; cur != NULL; cur = cur->next) |
| 9193 | 79 { |
|
10306
56cc5d49472b
[gaim-migrate @ 11492]
Luke Schierer <lschiere@pidgin.im>
parents:
10284
diff
changeset
|
80 /* Something is pointing to this slpmsg, so we should remove that |
|
56cc5d49472b
[gaim-migrate @ 11492]
Luke Schierer <lschiere@pidgin.im>
parents:
10284
diff
changeset
|
81 * pointer to prevent a crash. */ |
|
56cc5d49472b
[gaim-migrate @ 11492]
Luke Schierer <lschiere@pidgin.im>
parents:
10284
diff
changeset
|
82 /* Ex: a user goes offline and after that we receive an ACK */ |
|
56cc5d49472b
[gaim-migrate @ 11492]
Luke Schierer <lschiere@pidgin.im>
parents:
10284
diff
changeset
|
83 |
| 10345 | 84 MsnMessage *msg = cur->data; |
| 10284 | 85 |
| 10345 | 86 #ifdef MSN_DEBUG_SLPMSG |
| 87 gaim_debug_info("msn", "Unlink slpmsg callbacks.\n"); | |
|
10306
56cc5d49472b
[gaim-migrate @ 11492]
Luke Schierer <lschiere@pidgin.im>
parents:
10284
diff
changeset
|
88 #endif |
| 10345 | 89 |
| 90 msg->ack_cb = NULL; | |
| 91 msg->nak_cb = NULL; | |
| 92 msg->ack_data = NULL; | |
| 9193 | 93 } |
| 94 | |
| 10345 | 95 slplink->slp_msgs = g_list_remove(slplink->slp_msgs, slpmsg); |
| 9193 | 96 |
| 97 g_free(slpmsg); | |
| 98 } | |
| 99 | |
| 100 void | |
| 101 msn_slpmsg_set_body(MsnSlpMessage *slpmsg, const char *body, | |
| 102 long long size) | |
| 103 { | |
| 104 if (body != NULL) | |
| 105 slpmsg->buffer = g_memdup(body, size); | |
| 106 else | |
| 11164 | 107 slpmsg->buffer = g_new0(guchar, size); |
|
9198
ab6636c5a136
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
9193
diff
changeset
|
108 |
| 9193 | 109 slpmsg->size = size; |
| 110 } | |
| 111 | |
| 112 void | |
| 113 msn_slpmsg_open_file(MsnSlpMessage *slpmsg, const char *file_name) | |
| 114 { | |
| 115 struct stat st; | |
| 116 | |
|
10589
0f7452b1f777
[gaim-migrate @ 11994]
Daniel Atallah <daniel.atallah@gmail.com>
parents:
10345
diff
changeset
|
117 slpmsg->fp = g_fopen(file_name, "rb"); |
| 9193 | 118 |
|
10589
0f7452b1f777
[gaim-migrate @ 11994]
Daniel Atallah <daniel.atallah@gmail.com>
parents:
10345
diff
changeset
|
119 if (g_stat(file_name, &st) == 0) |
| 9193 | 120 slpmsg->size = st.st_size; |
| 121 } | |
| 122 | |
| 10345 | 123 #ifdef MSN_DEBUG_SLP |
| 11321 | 124 void |
| 9193 | 125 msn_slpmsg_show(MsnMessage *msg) |
| 126 { | |
| 127 const char *info; | |
| 128 gboolean text; | |
| 129 guint32 flags; | |
| 130 | |
| 131 text = FALSE; | |
| 132 | |
| 9775 | 133 flags = GUINT32_TO_LE(msg->msnslp_header.flags); |
| 9193 | 134 |
| 135 switch (flags) | |
| 136 { | |
| 137 case 0x0: | |
| 138 info = "SLP CONTROL"; | |
| 139 text = TRUE; | |
| 140 break; | |
| 141 case 0x2: | |
| 142 info = "SLP ACK"; break; | |
| 143 case 0x20: | |
| 10225 | 144 case 0x1000030: |
| 9193 | 145 info = "SLP DATA"; break; |
| 146 default: | |
| 147 info = "SLP UNKNOWN"; break; | |
| 148 } | |
| 149 | |
| 150 msn_message_show_readable(msg, info, text); | |
| 151 } | |
| 152 #endif | |
| 153 | |
| 154 MsnSlpMessage * | |
| 155 msn_slpmsg_sip_new(MsnSlpCall *slpcall, int cseq, | |
| 156 const char *header, const char *branch, | |
| 157 const char *content_type, const char *content) | |
| 158 { | |
| 159 MsnSlpLink *slplink; | |
| 160 MsnSlpMessage *slpmsg; | |
| 161 char *body; | |
| 162 gsize body_len; | |
| 163 gsize content_len; | |
| 164 | |
| 165 g_return_val_if_fail(slpcall != NULL, NULL); | |
| 166 g_return_val_if_fail(header != NULL, NULL); | |
| 167 | |
| 168 slplink = slpcall->slplink; | |
| 169 | |
| 170 /* Let's remember that "content" should end with a 0x00 */ | |
| 171 | |
| 172 content_len = (content != NULL) ? strlen(content) + 1 : 0; | |
| 173 | |
| 174 body = g_strdup_printf( | |
| 175 "%s\r\n" | |
| 176 "To: <msnmsgr:%s>\r\n" | |
| 177 "From: <msnmsgr:%s>\r\n" | |
| 178 "Via: MSNSLP/1.0/TLP ;branch={%s}\r\n" | |
| 179 "CSeq: %d\r\n" | |
| 180 "Call-ID: {%s}\r\n" | |
| 181 "Max-Forwards: 0\r\n" | |
| 182 "Content-Type: %s\r\n" | |
| 10112 | 183 "Content-Length: %" G_GSIZE_FORMAT "\r\n" |
| 9193 | 184 "\r\n", |
| 185 header, | |
| 186 slplink->remote_user, | |
| 187 slplink->local_user, | |
| 188 branch, | |
| 189 cseq, | |
| 190 slpcall->id, | |
| 191 content_type, | |
| 192 content_len); | |
| 193 | |
| 194 body_len = strlen(body); | |
| 195 | |
| 196 if (content_len > 0) | |
| 197 { | |
| 198 body_len += content_len; | |
| 199 body = g_realloc(body, body_len); | |
| 200 g_strlcat(body, content, body_len); | |
| 201 } | |
| 202 | |
| 203 slpmsg = msn_slpmsg_new(slplink); | |
| 204 msn_slpmsg_set_body(slpmsg, body, body_len); | |
| 205 | |
| 206 slpmsg->sip = TRUE; | |
| 10345 | 207 slpmsg->slpcall = slpcall; |
| 9193 | 208 |
| 209 g_free(body); | |
| 210 | |
| 211 return slpmsg; | |
| 212 } |
