Mercurial > pidgin
annotate src/protocols/zephyr/ZSendNot.c @ 13905:4e44ecb866bd
[gaim-migrate @ 16394]
msn_session_sync_users() iterates over the buddy list, following the ->next pointers of the groups, contacts, and buddies. msn_show_sync_issue(), if called, removed the buddy for which it was called, in preparation for the buddy either being added to the server list or confirmed-to-be-removed. This could lead to the buddy pointer being released and ->next therefore being junk.
The buddy is now not removed until the user responds to the action dialog presented via msn_show_sync_issue(). I'm unclear why gtkgaim got away with this exercise in memory stomping but Adium/libgaim crashed every time, but it's safer in any case.
I also changed some foo->bar to gaim_foo_get_bar().
committer: Tailor Script <tailor@pidgin.im>
| author | Evan Schoenberg <evan.s@dreskin.net> |
|---|---|
| date | Sun, 02 Jul 2006 09:37:25 +0000 |
| parents | 64895571248f |
| children |
| rev | line source |
|---|---|
| 2086 | 1 /* This file is part of the Project Athena Zephyr Notification System. |
| 2 * It contains source for the ZSendNotice function. | |
| 3 * | |
| 4 * Created by: Robert French | |
| 5 * | |
| 6 * Copyright (c) 1987 by the Massachusetts Institute of Technology. | |
| 7 * For copying and distribution information, see the file | |
| 8 * "mit-copyright.h". | |
| 9 */ | |
| 10 | |
|
8792
43d6c08d7e96
[gaim-migrate @ 9554]
Christian Hammond <chipx86@chipx86.com>
parents:
2086
diff
changeset
|
11 #include "internal.h" |
| 2086 | 12 |
| 13 Code_t ZSendNotice(notice, cert_routine) | |
| 14 ZNotice_t *notice; | |
| 15 Z_AuthProc cert_routine; | |
| 16 { | |
| 17 return(ZSrvSendNotice(notice, cert_routine, Z_XmitFragment)); | |
| 18 } | |
| 19 | |
| 20 Code_t ZSrvSendNotice(notice, cert_routine, send_routine) | |
| 21 ZNotice_t *notice; | |
| 22 Z_AuthProc cert_routine; | |
| 23 Code_t (*send_routine)(); | |
| 24 { | |
| 25 Code_t retval; | |
| 26 ZNotice_t newnotice; | |
| 27 char *buffer; | |
| 28 int len; | |
| 29 | |
| 30 if ((retval = ZFormatNotice(notice, &buffer, &len, | |
| 31 cert_routine)) != ZERR_NONE) | |
| 32 return (retval); | |
| 33 | |
| 34 if ((retval = ZParseNotice(buffer, len, &newnotice)) != ZERR_NONE) | |
| 35 return (retval); | |
| 36 | |
| 37 retval = Z_SendFragmentedNotice(&newnotice, len, cert_routine, | |
| 38 send_routine); | |
| 39 | |
| 40 free(buffer); | |
| 41 | |
| 42 return (retval); | |
| 43 } |
