Mercurial > pidgin.yaz
diff src/dialogs.c @ 5959:0a2a32b1917c
[gaim-migrate @ 6405]
Some minor UI fixes from yours truely:
-Closing a conversation that has a "select image to insert" dialog open
now also closes and frees the "select image to insert" dialog.
-The buddy icon selection dialog now lets you type, eg "~/.gaim/icons"
and hit enter without it thinking you've selected "~/.gaim/icons" as
your buddy icon. It will instead change the icon selection dialog to
that directory.
-Same for the "select file to send" dialog.
-Same for the right-click-on-an-icon "save icon" dialog.
-Same for the right-click-on-an-IM-image "save image" dialog.
-Same for buddy pounce "select sound" and "select program" dialogs.
I think there is a small leak here, but I don't have time to figure
it out. Someone should memprof this. I think it's gtkpounce.c line 140.
-Same for toc's "select file to send" dialog. This needs to change--
toc has gtk code in it.
-Made file_is_dir() accept a GtkFileSelection rather than a GtkWidget
(there is no reason it would need to accept anything other than a
GtkFileSelection)
-Some minor pounce dialog memleak fixes, I think. The hash table wasn't
getting freed on cancel.
Line 4960 of gtkconv.c might be leaking somehow. Someone should look
into that.
committer: Tailor Script <tailor@pidgin.im>
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Thu, 26 Jun 2003 02:01:56 +0000 |
| parents | b432fa240263 |
| children | 5fb6bd688a5b |
line wrap: on
line diff
--- a/src/dialogs.c Wed Jun 25 22:30:49 2003 +0000 +++ b/src/dialogs.c Thu Jun 26 02:01:56 2003 +0000 @@ -2495,7 +2495,7 @@ strncpy(path, file, PATHSIZE - 1); - if (file_is_dir(path, gtkconv->dialogs.log)) + if (file_is_dir(path, GTK_FILE_SELECTION(gtkconv->dialogs.log))) return; l = (struct log_conversation *)g_new0(struct log_conversation, 1); @@ -3806,7 +3806,7 @@ file = (const char*)gtk_file_selection_get_filename(GTK_FILE_SELECTION(filesel)); strncpy(path, file, PATHSIZE - 1); - if (file_is_dir(path, filesel)) + if (file_is_dir(path, GTK_FILE_SELECTION(filesel))) return; if ((fp_new = fopen(path, "w")) == NULL) { @@ -4504,7 +4504,7 @@ return button; } -int file_is_dir(const char *path, GtkWidget *w) +int file_is_dir(const char *path, GtkFileSelection *w) { struct stat st; char *name; @@ -4516,7 +4516,7 @@ } else { name = g_strdup(path); } - gtk_file_selection_set_filename(GTK_FILE_SELECTION(w), name); + gtk_file_selection_set_filename(w, name); g_free(name); return 1; }
