comparison src/plugin.c @ 5941:a3e60ff95b7d

[gaim-migrate @ 6381] Fixed a rather good-sized memory leak in plugins. Thanks to faceprint for pointing it out. I thought it was memprof being confused, but it turns out that in the gaim_plugin_destroy() function, we return early if a loader plugin for a non-native plugin cannot be found. That is no good. The check was there to prevent the loader plugin's destroy_plugin() from being called, but the proper fix was just to wrap that in an if statement. committer: Tailor Script <[e-mail]>

5940:94ad4d45346a

		GaimPlugin *loader;
		GaimPluginLoaderInfo *loader_info;

		loader = find_loader_for_plugin(plugin);

		if (loader == NULL)
			return;

		loader_info = GAIM_PLUGIN_LOADER_INFO(loader);

		if (loader_info->destroy != NULL)
			loader_info->destroy(plugin);
	}

	if (plugin->path  != NULL) g_free(plugin->path);
	if (plugin->error != NULL) g_free(plugin->error);

5941:a3e60ff95b7d

		GaimPlugin *loader;
		GaimPluginLoaderInfo *loader_info;

		loader = find_loader_for_plugin(plugin);

		if (loader != NULL) {
			loader_info = GAIM_PLUGIN_LOADER_INFO(loader);

			if (loader_info->destroy != NULL)
				loader_info->destroy(plugin);
		}
	}

	if (plugin->path  != NULL) g_free(plugin->path);
	if (plugin->error != NULL) g_free(plugin->error);