Mercurial > audlegacy

diff src/audacious/util.c @ 2607:65543c999c7e trunk

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[svn] Check filesize before doing memcmp (potential sigsegv).
author hansmi
date Mon, 05 Mar 2007 13:43:09 -0800
parents a221f10fd105
children fe33bdd3d5ad
line wrap: on
line diff
--- a/src/audacious/util.c	Sun Mar 04 10:43:38 2007 -0800
+++ b/src/audacious/util.c	Mon Mar 05 13:43:09 2007 -0800
@@ -420,7 +420,7 @@
      * by incomp@#audacious. Cleanups \nenolod
      * FIXME: can't we use a GLib function for that? -- 01mf02
      */
-    if (!memcmp(&buffer[0],&x,2))
+    if (filesize > 2 && !memcmp(&buffer[0],&x,2))
     {
         gchar *outbuf = g_malloc (filesize);   /* it's safe to waste memory. */
         guint counter;