comparison src/audacious/pluginenum.c @ 2624:840fb578a834 trunk

[svn] - [security, backport to 1.3] fix improper comparisons of hashtables used by the plugin loader.
author nenolod
date Fri, 16 Mar 2007 00:25:44 -0700
parents 0ad10a95ed10
children c3cd6e47faf6
comparison
equal deleted inserted replaced
2623:0ad10a95ed10 2624:840fb578a834
279 if (!g_module_supported()) { 279 if (!g_module_supported()) {
280 report_error("Module loading not supported! Plugins will not be loaded.\n"); 280 report_error("Module loading not supported! Plugins will not be loaded.\n");
281 return; 281 return;
282 } 282 }
283 283
284 /* 284 plugin_matrix = g_hash_table_new_full(g_str_hash, g_str_equal, g_free,
285 * FIXME: this collides in many cases. this is really bad.
286 * i have no idea why we use a hashtable here, there is no point, when
287 * a list of enabled plugins would realistically offer the same
288 * scalability. - nenolod
289 */
290 plugin_matrix = g_hash_table_new_full(g_str_hash, g_int_equal, g_free,
291 NULL); 285 NULL);
292 286
293 #ifndef DISABLE_USER_PLUGIN_DIR 287 #ifndef DISABLE_USER_PLUGIN_DIR
294 scan_plugins(bmp_paths[BMP_PATH_USER_PLUGIN_DIR]); 288 scan_plugins(bmp_paths[BMP_PATH_USER_PLUGIN_DIR]);
295 /* 289 /*