comparison src/audacious/pluginenum.c @ 2400:4daf4fa409e0 trunk

[svn] - make a note that hashtable collisions in the plugin matrix are not only possible, but happening, and have strange side effects.
author nenolod
date Thu, 25 Jan 2007 01:52:51 -0800
parents ad1d7687814c
children 0ad10a95ed10
comparison
equal deleted inserted replaced
2399:9b7b11176d4e 2400:4daf4fa409e0
275 if (!g_module_supported()) { 275 if (!g_module_supported()) {
276 report_error("Module loading not supported! Plugins will not be loaded.\n"); 276 report_error("Module loading not supported! Plugins will not be loaded.\n");
277 return; 277 return;
278 } 278 }
279 279
280 /*
281 * FIXME: this collides in many cases. this is really bad.
282 * i have no idea why we use a hashtable here, there is no point, when
283 * a list of enabled plugins would realistically offer the same
284 * scalability. - nenolod
285 */
280 plugin_matrix = g_hash_table_new_full(g_str_hash, g_int_equal, g_free, 286 plugin_matrix = g_hash_table_new_full(g_str_hash, g_int_equal, g_free,
281 NULL); 287 NULL);
282 288
283 #ifndef DISABLE_USER_PLUGIN_DIR 289 #ifndef DISABLE_USER_PLUGIN_DIR
284 scan_plugins(bmp_paths[BMP_PATH_USER_PLUGIN_DIR]); 290 scan_plugins(bmp_paths[BMP_PATH_USER_PLUGIN_DIR]);